Enhancement - Move Redis URL Configuration from config.toml to an Environment Variable #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bekossy, any reason why we are still experiencing this timeout error?
|
aakrem
requested changes
Nov 21, 2023
There was a problem hiding this comment.
we are still reading it from here :
https://github.com/bekossy/agenta/blob/main/agenta-backend/agenta_backend/utils/redis_utils.py#L13
It failed because it timed out while waiting for the request but it’s all good now. |
aakrem
reviewed
Nov 22, 2023
aakrem
requested changes
Nov 22, 2023
aakrem
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR moves redis url configuration from config.toml to an environment variable
Related Issue
Closes #915